slack-ruby-client icon indicating copy to clipboard operation
slack-ruby-client copied to clipboard

ruby 2.7.1 picky throwing deprecation warning

Open sonjz opened this issue 5 years ago • 4 comments

Noticed this deprecation warning on picky which I've loaded to use the search function.

/Users/user/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/picky-4.31.3/lib/picky/index.rb:128: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
(__FORWARDING__):1: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/user/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/picky-4.31.3/lib/picky/category_realtime.rb:14: warning: The called method `add' is defined here

there is a PR on picky, but hasn't been worked on for 5 years. https://github.com/floere/picky/pull/150#pullrequestreview-441328929

sonjz avatar Jul 02 '20 03:07 sonjz

If you/someone wants to investigate, find out what brings picky in, we don't have any direct dependencies on it.

dblock avatar Jul 02 '20 14:07 dblock

@dblock no worries PR in the works by picky, will verify and come back to close https://github.com/floere/picky/pull/150#issuecomment-652836899

sonjz avatar Jul 07 '20 18:07 sonjz

floere doesn't appear to be updating the package, and i tried a patch and it didn't work.

any thoughts on deprecating Picky for something else?

I'd like to use it for user_search.

sonjz avatar Oct 26 '21 22:10 sonjz

Gladly will take PRs.

dblock avatar Oct 28 '21 14:10 dblock