slack icon indicating copy to clipboard operation
slack copied to clipboard

Published 20 hours ago • verified publisher icon slack-go

Add include_num_members support to conversation.info request

Open Yohan460 opened this issue 3 years ago • 9 comments

Add include_num_members support to conversation.info request

Yohan460 avatar Oct 21 '21 00:10 Yohan460

Hey @kanata2 👋

Out of curiosity, is there any cadence for releases here? Would really love to get this merged in to resolve a dependency we have.

Many Thanks,

Johan

Yohan460 avatar Oct 28 '21 13:10 Yohan460

@Yohan460 Thanks for submitting PR! This PR has backward-incompatibility changes. So we'll release this in the next minor version(= v.10.0) if approved.

kanata2 avatar Oct 29 '21 18:10 kanata2

Updated the GPG key signing, haven't done pubilc PRs for a long time. The most recent commit should go verified eventually

Yohan460 avatar Nov 24 '21 16:11 Yohan460

@Yohan460 It seems that the lint phase in CI failed, so please confirm it.

kanata2 avatar Jan 09 '22 20:01 kanata2

@kanata2 The lint failure is un-related to my changes and appears to be due to a failure in the CI/CD pipeline. If you could take a look it would be appreciated

Yohan460 avatar Feb 09 '22 21:02 Yohan460

Could you run gofmt -w conversation.go?

kanata2 avatar Feb 12 '22 12:02 kanata2

done, could you re-trigger CI for me?

Yohan460 avatar Feb 13 '22 19:02 Yohan460

@Yohan460 Hi, this is newer slack-go maintainer.

I'll review this pull request later. Thanks for contribution.

zchee avatar Feb 26 '22 10:02 zchee

bumping this @zchee @kanata2 🥺 🙏

Yohan460 avatar Apr 11 '22 17:04 Yohan460