slack icon indicating copy to clipboard operation
slack copied to clipboard

Add team integration logs API

Open naormatania opened this issue 4 years ago • 7 comments

Add support for https://api.slack.com/methods/team.integrationLogs Add unittest to check it works as expected Also ran make pr-prep to check it's ready for review

naormatania avatar Apr 05 '21 15:04 naormatania

@naormatania When I tried it, I came across strange behavior. Slack documentation says that the service_id field is string, but actual response's one is not string but int... So slack-go/slack could not decode. I'll confirm Slack support.

kanata2 avatar Apr 20 '21 23:04 kanata2

@kanata2 has slack support answered about this issue ?

naorsec avatar May 11 '21 08:05 naorsec

Sorry for delay. According to support, this is documentation's mistake.

kanata2 avatar May 11 '21 08:05 kanata2

@kanata2 it seems like slack updated their documentation that service_id can be both int or string. I changed PR to handle both cases. let me know what you think. thanks !

naormatania avatar May 17 '21 17:05 naormatania

@naormatania I confirmed support again. According to support's response, the type of service_id is only integer, so we do not seem to need to consider the string type. :sob:

kanata2 avatar May 19 '21 02:05 kanata2

Thanks for the help @kanata2 ! I changed it to int now

naormatania avatar May 21 '21 04:05 naormatania

@naormatania

thanks! I found a new undocumented behavior... It seems that the user_id can be 0 (= a number) like following example.

        {
            "user_id": 0,
            "user_name": "slack",
            "date": "1595673313",
            "change_type": "disabled",
            "reason": "channel_archive",
            "service_id": 123456789,
            "service_type": "Incoming WebHooks",
            "scope": "incoming-webhook"
        }

kanata2 avatar May 30 '21 21:05 kanata2

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Apr 05 '23 23:04 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Apr 17 '23 00:04 github-actions[bot]