slack icon indicating copy to clipboard operation
slack copied to clipboard

Add support for title argument in CreateChannelCanvas method

Open jarospisak-unity opened this issue 2 months ago • 2 comments

This PR adds support for title argument in the CreateChannelCanvas method.

Closes #1482.

jarospisak-unity avatar Oct 01 '25 13:10 jarospisak-unity

Hi @jarospisak-unity. As it stands this is a breaking change and I'd rather not add breaking changes if they can be avoided at all.

One way is simply to add a method that allows to pass options. This pattern already exists in other parts of the codebase. Happy for you to give it a go if you're ok to do so, alternatively, I'll come back to this soon-ish.

func (api *Client) CreateChannelCanvasWithOptions(channel string, options
  ...CreateChannelCanvasOption) (string, error) {
      return api.CreateChannelCanvasWithOptionsContext(context.Background(), channel,
  options...)
  }
[...]

nlopes avatar Oct 26 '25 18:10 nlopes

@nlopes thanks for the feedback, I wasn't aware of that pattern. I'll refactor this pull request.

jarospisak-unity avatar Oct 27 '25 11:10 jarospisak-unity