quill
quill copied to clipboard
Published
20 hours ago •
slab
slab
Formula tooltip of existing formula is empty
[Describe the issue] Clicking on a formula should let you edit it inline or open the formula tooltip with the existing formula so you can edit it with latex.
Steps for Reproduction
- Visit http://beta.quilljs.com/
- Click on a formula
Expected behavior: [expected] Formula Tooltip should open with existing formula
Actual behavior: [actual] Tooltip doesn't show
Platforms: Chrome 51 on Windows 7
Version: [version] 1.0-beta9
https://github.com/quilljs/quill/pull/1992 This is a patch for #801, a few notes.
- I looked into doing unit tests but that would add a dependency on for katex and did not add any
- With this modification the tool tip does not have a preview, it goes straight to editing. There is some pro's and cons to this
- On chrome the area which triggers the selection event does not cover the entire formula, this is likely a separate issue, on larger formula's it is about 80% on smaller formula's it's the first character.
The following is the configuration I used for testing.
<!DOCTYPE html>
<html lang="en">
<head>
<title>Formula Module - Quill Rich Text Editor</title>
<meta charset="utf-8">
</head>
<body>
<!-- Include Quill stylesheet -->
<link href="dist/quill.snow.css" rel="stylesheet">
<link href="node_modules/katex/dist/katex.css" rel="stylesheet">
<!-- Create the editor container -->
<div id="editor">
<p>Hello World!</p>
</div>
<!-- Include the Quill library -->
<script src="node_modules/katex/dist/katex.js"></script>
<script src="dist/quill.js"></script>
<!-- Initialize Quill editor -->
<script>
var editor = new Quill('#editor', {
modules: {
formula: true, // Include formula module
toolbar: [['formula', 'link']] // Include button in toolbar
},
theme: 'snow'
});
</script>
</body></html>
I made a pr 6 years ago, it was ignored. How long should someone maintain a pr?