quill icon indicating copy to clipboard operation
quill copied to clipboard

Toolbar: add aria-pressed to toolbar buttons

Open cmrd-senya opened this issue 3 years ago • 2 comments

This adds aria-pressed attributes to Toolbar buttons. The attribute value set consistently with ql-active presence or absence.

Ref #2038

cmrd-senya avatar Jul 27 '22 11:07 cmrd-senya

CC @jhchen @luin

cmrd-senya avatar Jul 27 '22 11:07 cmrd-senya

The PR is updated to be compatible with the recent changes to TypeScript CC @luin

cmrd-senya avatar Sep 08 '22 11:09 cmrd-senya

Hi! Just wanted to bump this. Assuming this pull request accurately adds and toggles the aria-pressed attribute on the editor's buttons as it states (which it looks to me like it does), I'd like to advocate that this pull request be reviewed and merged as soon as possible. At my company, we have been working through an accessibility audit for the past couple years, where this lack of an aria-pressed attribute was flagged. Rather than needing to build our own custom solution, it would be great if we could simply update Quill on our end to a more accessible version so that the hundreds of thousands of both our customers and internal employees could benefit from this. Is there anything blocking this pull request from moving forward?

gbonker avatar Jan 04 '23 20:01 gbonker

Bumping this too. I also work in accessibility and getting this merged would solve a lot of headaches for developers and would improve the user experience for those dependent on assistive technology. I’m happy to help with testing if that’s what’s holding this up?

lindacodes avatar Apr 28 '23 11:04 lindacodes

Thanks for the contribution!

luin avatar Aug 07 '23 04:08 luin