sl-solution

Results 46 comments of sl-solution

> is it possible(or useful) to support `mapformats` in `flatten!`? it is very useful for the example from @sprmnt21 I moved this post to #57, so it is easier to...

On second thoughts, I classify this as a bug, ~~and a fix is coming soon~~.

> Are there any contraindications to the flatten function acting on the column: sds expanding (and possibly renaming the names to avoid conflicts) the rows of the subtables? Few remarks:...

> On second thoughts, I classify this as a bug, ~and a fix is coming soon~. Originally, I thought we could use a separate path for empty collections, however, this...

> does flatten `Int[]` as `nothing` solve this problem? probably not, since dealing with `nothing` is not easy. `IMD` handles `missing` for many function efficiently, however, `nothing` will be inconvenient.

> I don't know what Int [] is exactly / formally, other than to think of it as an empty vector. > But leaving it as it is, could it...

Please add tests for you functions. `test/join.jl` has a test set for range join, you may put your tests there.

This is a good PR, however, I have some concerns about the way you implemented it. General feedback: * There are lots of code repeats * You should use `innerjoin`...

The first warning is a bug, and I am fixing it, however, for the second warning I need to learn how to fix it. Probably PrettyTables version 2 will fix...

This is helpful. If I understand it correctly, it suggests putting the .. out of table.