Warnings while running tests

Open gitboy16 opened this issue 3 years ago • 1 comments

Hi, I got the following warning twice while running tests on Julia 1.8.

Warning: broadcasting get property is deprecated for SubDataset and will be disallowed in the future. Use `ds[:, :x2] .= ... instead
  caller = macro expansion at broadcasting.jl:171 [inlined]

I am not sure whether it is intended or not. If yes maybe worth using @test_warn ? Also, just a suggestion, maybe use @testset to make the test summary nicer?

Thank you

Aug 19 '22 15:08 gitboy16

It should not be there because we have not supported "broadcasting get property" since day one. The reason why it is still there is because we copied some of those tests from DataFrames.jl and I did not polish it.

Aug 19 '22 18:08 sl-solution