InMemoryDatasets.jl icon indicating copy to clipboard operation
InMemoryDatasets.jl copied to clipboard

I accidently encountered failed tests in this part

Open sl-solution opened this issue 2 years ago • 1 comments

https://github.com/sl-solution/InMemoryDatasets.jl/blob/4220d4bdc03e95098c498ed4012b6bee8fe50eb1/test/join.jl#L811

I cannot reproduce it, however, it must be checked - e.g. make sure that it is not related to data race. Perhaps, it is due to cumsum!???

The problem is related to having mis-matched pool and refs in the output data sets.

sl-solution avatar Jun 07 '22 09:06 sl-solution

I changed cumsum!, and ran the package tests 400 times to make sure every thing is ok, however, keep it open for further investigation.

sl-solution avatar Jun 09 '22 21:06 sl-solution