InMemoryDatasets.jl icon indicating copy to clipboard operation
InMemoryDatasets.jl copied to clipboard

Make a decision about statistical functions in src/stat/stat.jl

Open sl-solution opened this issue 2 years ago • 4 comments

currently we redefined them for vector with missing values.

sl-solution avatar Dec 14 '21 09:12 sl-solution

Also the entire file https://github.com/sl-solution/InMemoryDatasets.jl/blob/9f781c309f90f1a4c1623f0e85c78209bf9d1b9a/src/missings/missings.jl is type piracy

giordano avatar Mar 22 '22 12:03 giordano

Posting a link to Eric Hanson's post on this issue on the Julia Discourse. The concerns raised about unexpected behavior, bugs, and non-composability need to be considered carefully. Data science workflows grow to use multiple packages for various functionality over time. It would be good to avoid unpredictability arising from changing Base behavior.

George9000 avatar Mar 22 '22 16:03 George9000

Also the entire file https://github.com/sl-solution/InMemoryDatasets.jl/blob/9f781c309f90f1a4c1623f0e85c78209bf9d1b9a/src/missings/missings.jl is type piracy

fixed.

sl-solution avatar Mar 22 '22 18:03 sl-solution

you may check master

sl-solution avatar Mar 22 '22 21:03 sl-solution