Alex Chi Z.

Results 600 comments of Alex Chi Z.

The whole image creation path uses `anyhow::Error` and does not have its own error type, which means that fully fixing this needs a big refactor around the result type. Given...

okay, seems like it's not a one-off thing, maybe I should fix it lol

Looks like Christian already got a fix: https://github.com/neondatabase/neon/pull/12376

Confirmed that it included the gate close error; let's see if tests are improving.

not reproducing in the past 3 days; but we got a new warning https://github.com/neondatabase/neon/issues/12369

I think it's fine to have it in `test_forward_compatibility` given it's running a previous version of the binary? Let's wait another week and see if it still reproduce.

Looks like we have a few test failures wrt offloads 🤣

I think we only need to cover the pageserver use case for now: it's totally fine to have extra files in the pageserver tenant file repo. I'll implement a version...

Discussion at https://github.com/neondatabase/neon/issues/6211#issuecomment-2020965697

maybe part of https://github.com/neondatabase/neon/issues/6211