Alex Chi Z. comments

Results 599 comments of


                                            Alex Chi Z.

Question about ReaderWriterLatch

Looks reasonable to me! I'm thinking of a fix...

Question about ReaderWriterLatch

But I think it's rare case that we will hit `MAX_READERS` -- it's `UINT_MAX` for now. I believe this bug is easier to be reproduced if we set `MAX_READERS` to...

project0 build failed

Please wait for our new gradescope for 2022 Fall. See https://github.com/cmu-db/bustub/issues/227 for more information. Thanks!

Type subsystem

I think it's time to reduce our type to varchar + integer (maybe decimal, float).

run valgrind failed with ASan runtime related error

We might be deprecating valgrind soon for ASAN, and this issue will be closed then. https://github.com/cmu-db/bustub/issues/277

Git clone --depth leads to unsuccess git push using url

Seems already fixed. Thanks for reporting.

BufferPoolManager.NewPage spec is unclear if the pages returned must be pinned

Fixed in this year. https://github.com/cmu-db/bustub/blob/4df5b13f317c86e1f0058135ede3a219b26f3578/src/include/buffer/buffer_pool_manager_instance.h#L66-L68

The old gradescope course is not maintained any more. We will publish a new one soon. We're also working on making bustub "compile anytime, run anywhere", e.g., by https://github.com/cmu-db/bustub/issues/270. Thanks...

why open mode has both set trunc and app when create a file in Diskmanager

I believe it's a bug. Indeed you'll also need `std::ios::in` in addition to `std::ios::binary | std::ios::trunc | std::ios::out` to open the file. I've proposed a PR to fix it. You...

SimpleDeleteTest in executor_test.cpp incorrectly checks if index does not have removed row anymore.

We'll deprecate executor test (unit test) this semester. Won't fix.