Alex Chi Z.
Alex Chi Z.
Yes, that's true 🤣 btw I just realized that Postgres parser will convert everything to lowercase, so we might follow its convention and just convert everything to lowercase.
Oh, you're right. I mean all identifiers (like table name, column name) are lowercase. Probably we only need to make all table / column case-insensitive in binder.
```rust pub struct Version(u64, Arc); impl Drop for Version { // ... } pub fn pin(&self) -> Arc { /* .. */ } ```
Sure, thanks for that!
🤣🤣 surprised to see `count = 1`
... and I guess it would significantly reduce TPC-H's storage space
What's more, if we run import for the third time... ``` stack backtrace: 0: rust_begin_unwind at /rustc/5e57faa78aa7661c6000204591558f6665f11abc/library/std/src/panicking.rs:577:5 1: core::panicking::panic_fmt at /rustc/5e57faa78aa7661c6000204591558f6665f11abc/library/core/src/panicking.rs:110:14 2: core::result::unwrap_failed at /rustc/5e57faa78aa7661c6000204591558f6665f11abc/library/core/src/result.rs:1737:5 3: risinglight::executor::copy_from_file::CopyFromFileExecutor::read_file_blocking 4: tokio::loom::std::unsafe_cell::UnsafeCell::with_mut 5:...
Yes for sure... Also one RowSet has multiple columns, so maybe ~10 RowSets would exceed 128 limit.
@nanderstabel will take this issue. Thanks for your contribution!
Currently, the NLJ will output: ``` > create table t1(v1 int not null); created in 22ms 578us 583ns > create table t2(v1 int not null); created in 22ms 385us 875ns...