atom-shell-commands icon indicating copy to clipboard operation
atom-shell-commands copied to clipboard

Dosen't Support Chinese ?

Open forhuan opened this issue 7 years ago • 10 comments

qq 20170302143917

forhuan avatar Mar 02 '17 07:03 forhuan

i use iconv-lite-0.2.11 qq 20170302212945

and it finally work qq 20170302143917

forhuan avatar Mar 02 '17 13:03 forhuan

Interesting. I noticed that Node actually has a built-in encoding system, which I am enabling in my fork. Would the UTF-8 encoding also work for you? Should I implement an encoding option in the settings?

dqsully avatar Mar 17 '17 05:03 dqsully

Sorry, for replying late, This repository is looking for maintainer now, https://github.com/skywind3000/atom-shell-commands/issues/20

skywind3000 avatar Mar 18 '17 10:03 skywind3000

@dqsully Sorry, for replying late , I don't think UTF-8 encoding work for me , I'll try it this afternoon , an encoding option is better . BTW , This is my first time to encounter with Node ( Laugh )

forhuan avatar Mar 26 '17 00:03 forhuan

@dqsully UTF-8 not work for me

forhuan avatar Mar 26 '17 13:03 forhuan

Are you able to copy the output from one of your programs into GitHub? Most websites, including GitHub, use UTF-8.

Also, did you use my fork dqs-shell-commands or the old atom-shell-commands? atom-shell-commands still does not support any encodings, but I was able to add UTF-8 to my dqs-shell-commands package.

dqsully avatar Mar 26 '17 16:03 dqsully

@dqsully I use the old one yesterday .

I use your fork this time , but it does't work too

qq 20170327120206

Here is the output

["D:\\Program Files (x86)\\arduino-1.8.0\\arduino_debug.exe","--verify",""]
���ڼ�������...
���ڳ�ʼ����...
����׼��������...
������֤...
[Finished in 1.15 seconds, with code 1]

I tried to chang the Active code page to 65001( UTF-8 ) in the cmd and it excute success

this doesn't effect to the output from atom

image

I can type chinese correctly using UTF-8 encoding in atom image

chinese test 中文测试

Interesting :)

forhuan avatar Mar 27 '17 04:03 forhuan

Thank you for testing this for me, I'll work on an encoding option soon.

dqsully avatar Mar 27 '17 04:03 dqsully

My pleasure :)

forhuan avatar Mar 27 '17 04:03 forhuan

I apologize for the delay, school got really busy, but within a couple weeks I should be able to integrate this into my package.

dqsully avatar May 07 '17 20:05 dqsully