Snap.swift icon indicating copy to clipboard operation
Snap.swift copied to clipboard

Write Failed Image if Reference image not found

Open ralfebert opened this issue 7 years ago • 2 comments

In case "Reference image not found" happens, it would be awesome if Snap.swift would write the Failed image.

ralfebert avatar Feb 26 '18 21:02 ralfebert

Hey @ralfebert, thanks for the feedback, that could be a nice addition, the only problem that I see it's that when the image was not found it's that you are on test mode and not recording one so we might not expect to actually write the image

skyweb07 avatar Feb 27 '18 22:02 skyweb07

Hmm, I see the point. The context for this was that I added a few more image asserts to a test and I wanted to record just these images without overwriting the existing ones. And Snap write the images when a test is failing, so it would not come as a surprise (I don't mean they should be written in the folder for the reference images, just in the 'Failed' folder). Do you have any example where this would cause trouble?

ralfebert avatar Feb 28 '18 09:02 ralfebert