skypy icon indicating copy to clipboard operation
skypy copied to clipboard

ENH: Time evolution Schechter amplitude

Open Lucia-Fonseca opened this issue 2 years ago • 2 comments

Description

This PR adds a function that returns the amplitude of the Schechter function for active galaxies based on equation (17) in de la Bella et al. 2021. Merging this PR closes #515.

Checklist

  • [x] Follow the Contributor Guidelines
  • [x] Write unit tests
  • [x] Write documentation strings
  • [x] Assign someone from your working team to review this pull request
  • [x] Assign someone from the infrastructure team to review this pull request

Lucia-Fonseca avatar Jul 06 '22 13:07 Lucia-Fonseca

why is it not passing all of the checks?

Lucia-Fonseca avatar Jul 06 '22 14:07 Lucia-Fonseca

Check the logs

>       assert output_today == phi_today
E       assert 0.0037757219092541604 == 0.00377572190925416

Given the relative numerical complexity of the function it seems reasonable that the results are not identical but agree to some high precision.

rrjbca avatar Jul 12 '22 08:07 rrjbca