skypy icon indicating copy to clipboard operation
skypy copied to clipboard

ENH: Rename noise keyword argument in redshifts_from_comoving_density function

Open rrjbca opened this issue 3 years ago • 0 comments

It was noted in the review for our JOSS paper that the keyword argument noise for the function redshifts_from_comoving_density has a misleading name. See the review comment here. They suggested renaming to fixed_N. My own suggestion would be shot_noise (or perhaps poisson). Since this would require a breaking API change, this should only be made as part of a future major release (if at all).

rrjbca avatar Aug 31 '21 08:08 rrjbca