skyplane
skyplane copied to clipboard
Ctrl-C during a deprovision operation should ask the user for confirmation to exit
~Need a way to interrupt skyplane cp
transfers mid-way by the user.~
We currently prevent users from exiting during a deprovision operation to avoid leaked VMs. A Ctrl-C during deprovision should ask the user if they want to exit the transfer truly with the understanding that VMs could be leaked.
@ShishirPatil This is a good idea but we already catch KeyboardInterrupt during transfers here: https://github.com/skyplane-project/skyplane/blob/218a4049c163a48a3eb3bbb87802a04f1ac55a65/skyplane/cli/cli_impl/cp_replicate.py#L339-L352
What is not working with this logic?
Verified that it successfully exits the CLI at every level but the VMs are not deprovisioned. Also for deprovisioning, keyboard Interrupt doesn't work (which may be the intended behavior?)
Adding a reference to @ShishirPatil's discussion: https://github.com/skyplane-project/skyplane/pull/592#issuecomment-1267906205
Is this still an issue?