skypilot icon indicating copy to clipboard operation
skypilot copied to clipboard

[Pools] Add heterogeneity support.

Open lloyd-brown opened this issue 1 month ago • 4 comments

Tested (run the relevant ones):

  • [ ] Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • [ ] Any manual or new tests for this PR (please specify below)
  • [ ] All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • [ ] Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • [ ] Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

lloyd-brown avatar Dec 16 '25 02:12 lloyd-brown

Summary of Changes

Hello @lloyd-brown, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the 'Pools' feature by introducing full support for heterogeneous resource configurations. This allows users to define jobs with flexible resource requirements (e.g., 'any_of' T4 or A100 GPUs), and the system will intelligently select and record the specific resource used from the available pool workers. The changes involve core logic updates for resource handling, database integration for tracking resolved resources, and the removal of prior limitations on heterogeneous pools, all validated by new, dedicated smoke tests.

Highlights

  • Heterogeneous Resource Support: The system now correctly handles tasks with 'any_of' or 'ordered' resource configurations, allowing for more flexible resource allocation in pools.
  • Dynamic Resource Resolution: When a job with heterogeneous resource requirements is scheduled, the specific resource chosen from the 'any_of'/'ordered' list is now recorded in the job's 'full_resources' in the database.
  • Removed Heterogeneity Restrictions: Previous validation that prevented the creation of pools with heterogeneous accelerators has been removed, enabling this feature.
  • Enhanced Resource-Aware Scheduling: The scheduling logic has been updated to account for heterogeneous resources, including a fallback mechanism for unresolved configurations and specific updates when a resource is selected.
  • New Smoke Tests: Comprehensive smoke tests have been added to validate the new heterogeneous pool functionality, including scenarios for 'any_of' accelerators and resource-aware scheduling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 16 '25 02:12 gemini-code-assist[bot]

/smoke-test -k test_pools_heterogeneous

lloyd-brown avatar Dec 16 '25 02:12 lloyd-brown

/smoke-test -k test_pools_heterogeneous

lloyd-brown avatar Dec 16 '25 04:12 lloyd-brown

/smoke-test -k test_pools

lloyd-brown avatar Dec 16 '25 07:12 lloyd-brown