[Dashboard] Fix Enabled Clouds During Kubernetes Refreshing
We previously had an issue where if Kubernetes was loading the cloud section would show 0 clouds enabled before eventually showing the true number of clouds enabled. We add a check to make sure we are finished loading the enabled cloud data before showing the number of clouds enabled.
Tested (run the relevant ones):
- [ ] Code formatting: install pre-commit (auto-check on commit) or
bash format.sh - [ ] Any manual or new tests for this PR (please specify below)
- [ ] All smoke tests:
/smoke-test(CI) orpytest tests/test_smoke.py(local) - [ ] Relevant individual tests:
/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local) - [ ] Backward compatibility:
/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)
Summary of Changes
Hello @lloyd-brown, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a user interface issue in the dashboard where the count of enabled clouds would incorrectly show zero during the initial loading of Kubernetes data. The changes implement a robust check to ensure that the cloud section accurately reflects the data's loading status, thereby preventing the display of erroneous information and enhancing the overall user experience by providing a more stable and reliable view of cloud infrastructure.
Highlights
- Preventing Misleading UI State: Introduced a check to prevent the dashboard from temporarily displaying '0 clouds enabled' while Kubernetes data is still loading, which previously caused a misleading user experience.
-
Conditional Cloud Display Logic: Modified the
workspaceEnabledCloudscomputation to returnnullwhen Kubernetes data is loading and no infrastructure data is yet available, signaling an incomplete loading state. -
Filtering Data During Loading: Updated the
filteredCloudInfraDatalogic to display all available cloud infrastructure data without filtering whenworkspaceEnabledCloudsisnull, ensuring a consistent display during the loading phase.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.