[Core] Up Migration Lock Timeout for Nebius
This PR address and issue seen in Nebius where jobs would fail with RuntimeError: Failed to initialize database due to a timeout when trying to acquire the lock at /home/ubuntu/.sky/locks/.state_db.lock. Please try again or manually remove the lock file if you believe it is stale. The trouble is that migration takes longer than the current timeout even though the API server and jobs controller are still in a fine state. By upping the timeout we fix the issue.
Tested (run the relevant ones):
- [ ] Code formatting: install pre-commit (auto-check on commit) or
bash format.sh - [ ] Any manual or new tests for this PR (please specify below)
- [ ] All smoke tests:
/smoke-test(CI) orpytest tests/test_smoke.py(local) - [ ] Relevant individual tests:
/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local) - [ ] Backward compatibility:
/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)
Summary of Changes
Hello @lloyd-brown, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a temporary change to the test_multi_tenant_managed_jobs smoke test. The modification replaces the immediate job cancellation in the test's teardown phase with a prolonged sleep command. This change is likely intended to facilitate debugging by allowing the jobs to remain active for a longer duration after the test execution, enabling manual inspection of their state.
Highlights
-
Test Teardown Modification: The
test_multi_tenant_managed_jobsfunction intests/smoke_tests/test_api_server.pyhas its teardown logic altered. The previoussky jobs cancelcommand is commented out and replaced with asleep 10000command, effectively pausing the teardown for an extended period.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
/smoke-test -k test_multi_tenant_managed_jobs --nebius
/smoke-test -k test_multi_tenant_managed_jobs --nebius
/smoke-test -k test_multi_tenant_managed_jobs --nebius