skypilot
skypilot copied to clipboard
[preview] Change column limit to 100
Even linux is using 100-column now: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144
I feel worse and worse when looking at files like sky/backends/cloud_vm_ray_backend.py. Every two of one lines of code you need to fold it into multiple lines. It’s like writing code on a tape.
A small nit: many of our previous comments followed the 80-character limit. Is it possible to stretch them automatically as well?
A small nit: many of our previous comments followed the 80-character limit. Is it possible to stretch them automatically as well?
Currently seems not supported. I can do it manually later.
A big +1 to this change. It looks really bad when a one-line function call has to be split into multiple lines, e.g.
(cluster_status,
handle) = backend_utils.refresh_cluster_status_handle(name)
I can update this PR after #763 and #759 get merged to minimize the trouble for re-formatting.
Are we still planning to merge this as the three main PRs (onprem, benchmark and logging) have been merged @suquark ? We can probably lazily make the comments and strings match the 100 character limit.