add tini to docker files

[Ajay-Satish-01]

Add tini to docker files #4750

Tested (run the relevant ones):

• [ ] Code formatting: install pre-commit (auto-check on commit) or bash format.sh
• [ ] Any manual or new tests for this PR (please specify below)
• [ ] All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
• [ ] Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
• [ ] Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

[aylei]

/quicktest-core

[Ajay-Satish-01]

For the follow-up PR, should I create a new preserve_entrypoint argument and include the command args only when we are not preserving the entry point?

[Michaelvll]

LGTM, thanks @Ajay-Satish-01! BTW, when launching containers on VM and Kubernetes, the docker run and k8s pod manifest will override entrypoint:

https://github.com/skypilot-org/skypilot/blob/052e0ea3b129f208a82fd9d6bddbfd39d389e831/sky/provision/docker_utils.py#L120

https://github.com/skypilot-org/skypilot/blob/052e0ea3b129f208a82fd9d6bddbfd39d389e831/sky/templates/kubernetes-ray.yml.j2

Would you like to also change these in followup PRs?

Should directly make the modification in this PR? It seems without changing the overwrite of entrypoint, this PR will not resolve #4750?

[Ajay-Satish-01]

@aylei can you please check if this is what you are expecting?

[github-actions[bot]]

This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions[bot]]

This PR was closed because it has been stalled for 10 days with no activity.