skypilot icon indicating copy to clipboard operation
skypilot copied to clipboard

[Feature Request] Logs of Setup

Open michaelzhiluo opened this issue 2 years ago • 5 comments

It'd be nice to be setup.log in ~/sky_logs/timestamp/.... In that case, I can happily debug environment from past iterations of debugging.

Edit: It is actually a bug instead.

michaelzhiluo avatar Oct 27 '22 03:10 michaelzhiluo

The setup-{ip}.log should appear in the ~/sky_logs/timestamp/....

https://github.com/skypilot-org/skypilot/blob/f49ed5aed4d180c18d7feddcb2733c61d9170441/sky/backends/cloud_vm_ray_backend.py#L1982-L1986

Just tested with the following yaml, and the setup-ip.log correctly shows up.

setup: |
  pip install jupyterlab
run: |
  nohup jupyter-lab --LabApp.token='' > /dev/null 2>&1 &

Do we want to close the issue @michaelzhiluo ?

Michaelvll avatar Oct 29 '22 10:10 Michaelvll

Should be a bug then @Michaelvll I dont see it after setting up resnet environment. Screen Shot 2022-10-31 at 2 48 17 AM

michaelzhiluo avatar Oct 31 '22 09:10 michaelzhiluo

The logs should be on your local machine, not on the remote VM.

Michaelvll avatar Oct 31 '22 18:10 Michaelvll

Was this originally intended to have different local and remote log directories? It was surprising that the directory contents on my laptop does not match remote and I would have never known otherwise.

Suggested fixes:

  1. Match setup.log for both remote and local.
  2. Have documentation that setup.log is only on local, etc.

michaelzhiluo avatar Nov 01 '22 04:11 michaelzhiluo

@Michaelvll If there is detach setup, is this fixed?

michaelzhiluo avatar Nov 13 '22 06:11 michaelzhiluo

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar May 29 '23 02:05 github-actions[bot]

We now have a --detach-setup option now. The problem should be fixed. : )

Michaelvll avatar May 29 '23 05:05 Michaelvll