ngx-google-places-autocomplete
ngx-google-places-autocomplete copied to clipboard
skynet2
chore: angular 10 updates
Should this branch work as is on Angular 10? The currently released version yields console warnings that it's a CommonJS dependency, so I was hoping this branch would remedy that, but this is all new to me. I tried:
npm install --save NathanWalker/ngx-google-places-autocomplete#feat/angular-10
What should my imports be updated to? I currently have
import { GooglePlaceModule } from 'ngx-google-places-autocomplete'; which yields:
TS2307: Cannot find module 'ngx-google-places-autocomplete' or its corresponding type declarations.
Is it just that types are missing? I see index.d.ts referenced but I don't see any declaration files. Any help appreciated.
@ccondrup i'm having this warning too, it'd be great to convert all CommonJS modules to ECMAScript modules, since CommonJS obstructs tree-shaking of modules. @skynet2, is there any chance to fix this, sir?
@skynet2 Any update on this? I would like to get the optimizations from removing the CommonJS modules and remove the warning from my build process.
@skynet2 Any update on this? I would like to get the optimizations from removing the CommonJS modules and remove the warning from my build process.
I think the devs have changed the tsconfig.json and replaced the CommonJS module with es2017 module..
Check the last commit here https://github.com/skynet2/ngx-google-places-autocomplete/pull/64/commits/f7cd3f3dc0cf45d7a95b39db582ac2b9585a43d6
