Vatsimphp icon indicating copy to clipboard operation
Vatsimphp copied to clipboard

JSON v3 - ATIS data is in a separate block

Open CaptainStealthy opened this issue 3 years ago • 3 comments

Looking at the code for the v3 parser, it only looks at objects within the controllers and pilots blocks, and ignores the atis block.

https://github.com/skymeyer/Vatsimphp/blob/60eb40c0bcf7dd58060ae529073fa25eb455dedd/src/Vatsimphp/Parser/DataV3CompatParser.php#L167

Would it be possible to have ATIS data added?

CaptainStealthy avatar Mar 31 '21 21:03 CaptainStealthy

I'll take a look over the weekend what we are missing.

Regardless of that, I have some newer code sitting ready so we can abandon the legacy format all together which will make everyone's life easier.

skymeyer avatar Apr 02 '21 11:04 skymeyer

Regardless of that, I have some newer code sitting ready so we can abandon the legacy format all together which will make everyone's life easier.

Is this code still using some of the legacy format as of today?

winternet-studio avatar Oct 17 '21 13:10 winternet-studio

I have been pretty busy the last months and completely overlooked finishing this up. The new code solely makes use of the JSON data simplifying the whole code base.

skymeyer avatar Oct 18 '21 23:10 skymeyer