jadx icon indicating copy to clipboard operation
jadx copied to clipboard

[gui] color of selected text is difficult to recognize in dark mode

Open moroal opened this issue 1 year ago • 3 comments

Issue details

It's not easy to recognize the color of 1,2,3 when I select 1

image

Jadx version

1.4.7

Java version

17.06

OS

  • [X] Windows
  • [ ] Linux
  • [ ] macOS

moroal avatar Jan 16 '24 06:01 moroal

@moroal looks like 2 and 3 not highlighted at all. Same names don't get highlighted if the cursor at the end of a word. This can be considered as an issue, I will look at it, thanks :+1:

skylot avatar Jan 17 '24 19:01 skylot

I fixed highlighting if cursor set at word end. This also simplify execution of code actions (like rename) for one letter identifiers. @moroal I am not sure if this is change you are asking for, so please check latest unstable build to check if change was helpful :slightly_smiling_face:

skylot avatar Jan 18 '24 21:01 skylot

Thank you very much. I have verified that the problem has been fixed except for monokai and druid themes, and it no longer affects my use. I just went on a vacation and I'm sorry for not being able to reply to your message in time.

image image

moroal avatar Feb 19 '24 03:02 moroal