[core]Unexpected Loop and Return

[jygzyc]

Describe error Loop and Return statements compile error Due to confidentiality reasons, I cannot provide relevant APK for the time being. But I can provide the smali result and JEB decompiling result. jadx:

JEB:

The smali code is here

.method public static a(Landroid/content/Context;Landroid/content/Intent;)Z
    .registers 4

    .line 1
    invoke-virtual {p0}, Landroid/content/Context;->getPackageManager()Landroid/content/pm/PackageManager;

    move-result-object p0

    const/high16 v0, 0x10000

    .line 2
    invoke-virtual {p0, p1, v0}, Landroid/content/pm/PackageManager;->queryIntentActivities(Landroid/content/Intent;I)Ljava/util/List;

    move-result-object p0

    const/4 p1, 0x0

    if-eqz p0, :cond_15

    .line 3
    invoke-interface {p0}, Ljava/util/List;->size()I

    move-result v0

    if-lez v0, :cond_15

    const/4 v0, 0x1

    goto :goto_16

    :cond_15
    move v0, p1

    :goto_16
    if-eqz v0, :cond_31

    .line 4
    invoke-interface {p0}, Ljava/util/List;->iterator()Ljava/util/Iterator;

    move-result-object p0

    :cond_1c
    invoke-interface {p0}, Ljava/util/Iterator;->hasNext()Z

    move-result v1

    if-eqz v1, :cond_31

    invoke-interface {p0}, Ljava/util/Iterator;->next()Ljava/lang/Object;

    move-result-object v1

    check-cast v1, Landroid/content/pm/ResolveInfo;

    .line 5
    iget-object v1, v1, Landroid/content/pm/ResolveInfo;->activityInfo:Landroid/content/pm/ActivityInfo;

    if-eqz v1, :cond_1c

    iget-boolean v1, v1, Landroid/content/pm/ActivityInfo;->exported:Z

    if-nez v1, :cond_1c

    goto :goto_32

    :cond_31
    move p1, v0

    .line 6
    :goto_32
    new-instance p0, Ljava/lang/StringBuilder;

    invoke-direct {p0}, Ljava/lang/StringBuilder;-><init>()V

    const-string v0, "isIntentAvaliable(intent):"

    invoke-virtual {p0, v0}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;

    invoke-virtual {p0, p1}, Ljava/lang/StringBuilder;->append(Z)Ljava/lang/StringBuilder;

    invoke-virtual {p0}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;

    move-result-object p0

    const-string v0, "IntentUtils"

    invoke-static {v0, p0}, Lcom/vivo/Tips/utils/M;->d(Ljava/lang/String;Ljava/lang/String;)V

    return p1
.end method

[jygzyc]

Plus: JEB smali result

.method public static a(Context, Intent)Z
          .registers 4
00000000  invoke-virtual      Context->getPackageManager()PackageManager, p0
00000006  move-result-object  p0
00000008  const/high16        v0, 0x00010000
0000000C  invoke-virtual      PackageManager->queryIntentActivities(Intent, I)List, p0, p1, v0
00000012  move-result-object  p0
00000014  const/4             p1, 0
00000016  if-eqz              p0, :2A
:1A
0000001A  invoke-interface    List->size()I, p0
00000020  move-result         v0
00000022  if-lez              v0, :2A
:26
00000026  const/4             v0, 1
00000028  goto                :2C
:2A
0000002A  move                v0, p1
:2C
0000002C  if-eqz              v0, :62
:30
00000030  invoke-interface    List->iterator()Iterator, p0
00000036  move-result-object  p0
:38
00000038  invoke-interface    Iterator->hasNext()Z, p0
0000003E  move-result         v1
00000040  if-eqz              v1, :62
:44
00000044  invoke-interface    Iterator->next()Object, p0
0000004A  move-result-object  v1
0000004C  check-cast          v1, ResolveInfo
00000050  iget-object         v1, v1, ResolveInfo->activityInfo:ActivityInfo
00000054  if-eqz              v1, :38
:58
00000058  iget-boolean        v1, v1, ActivityInfo->exported:Z
0000005C  if-nez              v1, :38
:60
00000060  goto                :64
:62
00000062  move                p1, v0
:64
00000064  new-instance        p0, StringBuilder
00000068  invoke-direct       StringBuilder-><init>()V, p0
0000006E  const-string        v0, "isIntentAvaliable(intent):"
00000072  invoke-virtual      StringBuilder->append(String)StringBuilder, p0, v0
00000078  invoke-virtual      StringBuilder->append(Z)StringBuilder, p0, p1
0000007E  invoke-virtual      StringBuilder->toString()String, p0
00000084  move-result-object  p0
00000086  const-string        v0, "IntentUtils"
0000008A  invoke-static       M->d(String, String)V, v0, p0
00000090  return              p1
.end method

[skylot]

@jygzyc thanks. Jadx trying to avoid code duplication, but in your case it is necessary and looks like jadx missed this case. Right now I am working on CFG checker pass, so jadx will be able to find and fix such cases.