jadx icon indicating copy to clipboard operation
jadx copied to clipboard

[core] Change access modifiers for fields

Open bagipro opened this issue 3 years ago • 0 comments

Hey,

Jadx is changing access modifiers for methods, but not for fields. An example is in class com.ebay.mobile.identity.SignInFactory$createBuilder$1:

    public void setRegistration(boolean z) {
        if (z != super.isRegistration()) {
            super.setRegistration(z);
            getIntent().setComponent(z ? (ComponentName) this.this$0.registrationComponentProvider.get() : this.signInComponent);
        }
    }

Field this.this$0.registrationComponentProvider has private access modifier:

public final class SignInFactory {
    private final javax.inject.Provider<android.content.ComponentName> registrationComponentProvider;

so it should be also fixed to public (or package-private is also possible in this case)

APK: https://drive.google.com/file/d/1qC3tlWs9AtPBpyS6iU9kcSphLryfJOxi/view

bagipro avatar Aug 22 '21 20:08 bagipro