skyline icon indicating copy to clipboard operation
skyline copied to clipboard

Gamepad null pointer error

Open android-1995 opened this issue 2 years ago • 3 comments

image

    override fun dispatchKeyEvent(event : KeyEvent) : Boolean {
        event.device ?: return super.dispatchKeyEvent(event)
        //Other original code
    }
    override fun onGenericMotionEvent(event : MotionEvent) : Boolean {
        event.device ?: return super.onGenericMotionEvent(event)
        //Other original code
    }

Wouldn't it be better to ignore some empty gamepad events?

android-1995 avatar Aug 10 '22 02:08 android-1995

This was closed by mistake, our apologies.

IvarWithoutBones avatar Aug 10 '22 18:08 IvarWithoutBones

Thanks for the report. We're planning a refactor of how input works in skyline and we'll fix this as a result of that.

nickbeth avatar Aug 10 '22 18:08 nickbeth

fine, thanks for your work

android-1995 avatar Aug 11 '22 00:08 android-1995

Did you notice any new instances of this error?

nickbeth avatar Oct 26 '22 21:10 nickbeth

No, is there any related code to change?

android-1995 avatar Oct 27 '22 00:10 android-1995

Nope, just checking before closing this

nickbeth avatar Oct 29 '22 15:10 nickbeth