skyline
skyline copied to clipboard
skyline-emu
Add version infos about rom
I have added version of rom infos inside:
App dialog
App Item Grid
App Item Grid Compact
App Item List
I'm not really sure if it is usefull to add it for app items, maybe adding it to the dialog could be good enough feel free to tell me :)
Note: This is the first time ever i've touched to cpp files, i've partially understand how it was working and made change to make it work, feel free to tell me if i made any mistake
Note 2: I've seen that there is a lot of informations that could be helpfull to users like Time player, Last Time Played, File Size and other that i'd like to add if you think there is an interest
They are not spamming anything, this is how pull requests work.
so what happens when the workflow gets approved?
It will get approved when all of the devs agree it's ready to be merged.
It will get approved when all of the devs agree it's ready to be merged.
ok thanks for helping me understand the process.
bro you're doing a great job but please stop spamming in the action tab
Did i spam ? I'm sorry if that's the case, i can try to push less often, I know I have a bad habit of commit and directly pushing. I'll do my best :)
It's fine don't worry about them Kikimanjaro, they are just unaware how GitHub works.
Seems a bit excessive in the grid, but not the dialog and list if it isn't a separate option from displaying any info at all. In the list, it helps fill in the whitespace and in the dialog, it's practically what is expected. In compat grid, it begins to overpower the actual icon. In the regular grid, it wouldn't make sense if it wasn't also in the compat.
(Just an opinion. Feel free to disregard it as rambling.)
LGTM! We'll merge after you squash the commits. Also thanks for the coauthor, but no need to, it's your code after all ;)
It makes you the coautor automatically when a apply one of your suggestion :) you helpped me a lot that's normal