Miha Valencic

Results 34 comments of Miha Valencic

Thanks for the feedback! I will look into it and if I decide to pursue this path, I will surely provide a PR. I'm currently still figuring out how make...

A couple more observations and questions: - running `extractpo` global tool finds 343 strings - running from source code finds 4 strings (only in files ending with `.cs`) even if...

So here is a "fix" that removes the project name from context (`msgctxt`) in the Razor CSHTML files: https://github.com/skyflyer/OrchardCoreContrib.PoExtractor/tree/msgctxt-without-project-name All tests are passing (none are written for Razor) and I've...

@hishamco, what are your thoughts on the workflow and proposed fix?

> Why do you want to remove the project name from the context? We use it to distinguish between two identical localization strings that are located in multiple projects Because,...

I just looked at the Orchard code: The [PO factory](https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore/OrchardCore.Localization.Core/PortableObject/PortableObjectStringLocalizerFactory.cs#L65) passes the context to the localizer and this context equals to `Views.Home.Index` (if the `IViewLocalizer` is injected into `Home/Index.cshtml` view....

I created a pull request which includes two unit tests and a change to remove the project name from the .cshtml msgctx. I created a sample project that this can...

> Are you on Linux? No, macOS. > IMHO, we need more unit tests to validate the inputs. Please propose a PR that fixes the issue, a unit or functional...

What do you mean by module? Like another project?

The [solution](https://github.com/skyflyer/DotnetPoLocalizationDemo) now contains a solution with a Web (MVC) and a Razor Class Library (RCL) which is shared. Food for thought: generate translation template looks like this: ``` #:...