android-ripple-background icon indicating copy to clipboard operation
android-ripple-background copied to clipboard

rippleStrokeWidth not used in Stroken Ripple Type

Open tudoubudou opened this issue 8 years ago • 5 comments

@@ -79,8 +79,10 @@ public class RippleBackground extends RelativeLayout{
         if(rippleType==DEFAULT_FILL_TYPE){
             rippleStrokeWidth=0;
             paint.setStyle(Paint.Style.FILL);
-        }else
-        }else{
-            paint.setStrokeWidth(rippleStrokeWidth);
           paint.setStyle(Paint.Style.STROKE);
-        }
       paint.setColor(rippleColor);

tudoubudou avatar May 09 '16 08:05 tudoubudou

Confirmed, I also spent time looking what I did wrong so the ripple is always 2dp but it seems that the issue is in the library.

ghost avatar Jun 13 '16 08:06 ghost

hey do you have an update relating the stroke width issue?

drorGlucome avatar Apr 30 '19 14:04 drorGlucome

@drorGlucome check out my modification "-" means remove the current line

tudoubudou avatar May 10 '19 18:05 tudoubudou

Thank you for the answer. So only way is to download the code modify and use as static lib?

drorGlucome avatar May 10 '19 20:05 drorGlucome

Thank you for the answer. So only way is to download the code modify and use as static lib?

yes

tudoubudou avatar May 15 '19 11:05 tudoubudou