Jaewoong Eum

Results 173 comments of Jaewoong Eum

Hey guys, would you try to build with the recent release, 1.1.0?

Duplicated with #30. This issue will be resolved in the next release.

Hey @AnthonyPicquet, do you mean this issue happens only with the non-modal option? For me, it works well with the modal option. ![Screenshot 2024-01-20 at 2 09 03 PM](https://github.com/skydoves/FlexibleBottomSheet/assets/24237865/e67d2b92-07d1-4e48-a48e-dd7300880c2b)

What do you mean by disabling hiding the bottom sheet when you dismiss? Isn't it meant to be the same as not dismissing?

@Uspesh Sounds interesting. Let me consider implementing the `skipHidden` property.

Hi everyone, apologies for the delayed response. Since version 0.1.3, you can prevent the bottom sheet from hiding and keep it displayed across user actions by setting the `skipHiddenState` property...

Hey @ghasemdev, would you elaborate on this? It sounds like this issue should be prevented from the user side. Does this work different from the Material3's `ModalBottomSheet`?

Hey @wseemann, audio doesn't work by adding a track on the Sink, which renders Video streams. You can refer to [handing audio tracks](https://github.com/GetStream/stream-video-android/blob/e6188f2b0cc582b55c2413ee37112fd959d12168/stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt#L510) from Stream's Video SDK.

Hey @wseemann, ah I got your question. Thanks for the details! Do you mean the audio sample callback listeners like this? - https://github.com/GetStream/stream-video-android/blob/ddea2579360cb09223c7f3f36dda22fd4d5fb3cb/stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/connection/StreamPeerConnectionFactory.kt#L207 - https://github.com/GetStream/stream-video-android/blob/ddea2579360cb09223c7f3f36dda22fd4d5fb3cb/stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/connection/StreamPeerConnectionFactory.kt#L210

Hi @Hector-IoT, sorry for the delayed response. You can create this PR to the [GetStream/webrtc](https://github.com/getstream/webrtc) repository, as this repository mirrors the native code from it. Once you re-create a PR...