Pokedex
Pokedex copied to clipboard
Issue #93: add pokemon id to pokemon list
Here is the result :
Because the fetch to pokemons list does not provide the pokemon id, i need to fetch pokemon infos by pokemon to catch it. It may slow down the loading of the application, but the result is here.
We could potentially check if the info of the pokemon is already stored in the data, if yes, use the stored data, if no, download it. It may reduce the number of pokeapi infos call.
Closes #93
Guidelines
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Preparing a pull request for review
Ensure your change is properly formatted by running:
$ ./gradlew spotlessApply
Please correct any failures before requesting a review.
@PlMrs https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
@skydoves What do you think?