ColorPickerView icon indicating copy to clipboard operation
ColorPickerView copied to clipboard

Published 20 hours ago • verified publisher icon skydoves

Zoom support

Open marcauberer opened this issue 5 years ago • 8 comments

Hi, first of all: Thanks for your awesome lib! One feature is missing after all: Support for zooming into the image. Some images might have very tiny color spots so that it's hard to pick the colors.

I would highly appreciate, if you would implement it!

marcauberer avatar May 25 '20 15:05 marcauberer

Hi, @marcauberer This issue sounds great. It could be a nice new feature! Thank you for your issue :)

skydoves avatar May 25 '20 15:05 skydoves

Any progress on this?

marcauberer avatar Sep 09 '20 14:09 marcauberer

@skydoves any good news about this feature?

ahmadbajwa12315 avatar Dec 01 '20 10:12 ahmadbajwa12315

@marcauberer hi, should we wait or go for something else for this?

ahmadbajwa12315 avatar Dec 15 '20 09:12 ahmadbajwa12315

Hi, I was thinking about this issue and the action is quite difficult to imagine. Zoomable means the image can be draggable with two fingers and also movable by touching the image. Hence, the zoomable actions would overlap and work together with a thumb for selecting a pixel from the image. A user wants to move the zoomed image, but the selector (thumb) will move together. (Or we need a boolean property for checking it is a zoomable mode or not). If you have any solutions for this, feel free to suggest any ideas. Thanks!

skydoves avatar Dec 23 '20 12:12 skydoves

You can button for this Boolean, if the user want to zoom we can set true. That how it will work separately.

On Wed, Dec 23, 2020 at 5:43 PM Jaewoong Eum [email protected] wrote:

Hi, I was thinking about this issue and the action is quite difficult to imagine. Zoomable means the image can be draggable with two fingers and also movable by touching the image. Hence, the zoomable actions will overlap and work together with moving a thumb for selecting a pixel from the image. A user wants to move the zoomed image, but the selector (thumb) will move together. (Or we need a boolean property for checking it is a zoomable mode or not). If you have any solutions for this, feel free to suggest me. Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/skydoves/ColorPickerView/issues/48#issuecomment-750278781, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARRSELARF4NR576IA3H4IILSWHQXRANCNFSM4NJTTPMQ .

ahmadbajwa12315 avatar Dec 23 '20 13:12 ahmadbajwa12315

@skydoves So still how much time you required to lunched this feature?

ahmadbajwa12315 avatar Dec 23 '20 15:12 ahmadbajwa12315

PR is open. You can contribute.

skydoves avatar Dec 23 '20 15:12 skydoves