skydive
skydive copied to clipboard
skydive-project
VPP memif
run skydive-cdd-overview-tests run skydive-functional-tests-backend-orientdb
run skydive-cdd-overview-tests run skydive-functional-tests-backend-elasticsearch run skydive-scale-tests
run skydive-cdd-overview-tests run skydive-functional-tests-backend-orientdb
@fgschwan We recently merged the support for seeds in Skydive : it's a single Skydive probe executed as a standalone process in the Docker namespace. This PR modifies the VPP existing probe to be able to run inside the namespace, using the socket interface. I integrated the memifs retrieval that you implemented and the links between them. I also cherry-picked the tests from your PR. It would be very nice if you could give it a try.
@fgschwan We recently merged the support for seeds in Skydive : it's a single Skydive probe executed as a standalone process in the Docker namespace. This PR modifies the VPP existing probe to be able to run inside the namespace, using the socket interface. I integrated the memifs retrieval that you implemented and the links between them. I also cherry-picked the tests from your PR. It would be very nice if you could give it a try.
@lebauce Hi, i'm currently quite busy with other things, but my colleague Milan Lenco could take a look at this PR and try to use it with running VPPs inside docker containers.
I was able to get it running and overall it looks good, only added few comments.
Also one general comment: If it is not already done/planned, I would also welcome if it was documented how to build and use vpp probe. For example mention that WITH_VPP=true has to be defined, that vpp probe is not loaded by default and needs to be listed in agent.topology.probes config and also document which version of VPP is supported out-of-the-box (for which version the binary API files have been generated and included in the repo).
@milanlenco Thanks a lot for taking the time to test and for the review. This is really useful, I will try to address the issues