skywire icon indicating copy to clipboard operation
skywire copied to clipboard

flag to show relevant visor logging on `skywire-cli proxy start` & `skywire-cli vpn start`

Open 0pcom opened this issue 2 years ago • 2 comments

The following is currently observed when starting the proxy or VPN from skywire-cli:

$ skywire-cli proxy start 0216356d7b5286d2c6ee9c579443c346f1d89bf86d9e8a6426d421580b3162d83c
Starting.............
Running!

After entering the command, Starting is printed, and every second it prints another . until the proxy has started, then it prints Running on a new line.

This was done because it might take the visor a while to get the needed transports and routes before even starting the proxy. So there would be no indication that anything was happening without even this simple logging.

When starting the proxy or VPN with skywire-cli it would be convenient if there was a flag to show the logging as it would print to the terminal if you were running the visor ; in order to have some idea of what was happening without needing the visor running in another terminal; or without needing to look anywhere else besides the terminal you are attempting to start the proxy or VPN in currently.

We should show only the logging specific to:

  • transport creation
  • route setup
  • the proxy or VPN starting

If invoked with the flag to show the logs ; it should:

  • keep logging from there, until you do ctrl+c
  • then stop the proxy or VPN.

With the flag that shows the logging, it should not give the terminal back until the proxy or VPN is stopped & it should be possible to stop it with ctrl+c

I recommend a similar flag to show logging for transport creation, at least.

0pcom avatar Nov 24 '23 16:11 0pcom

Unfortunately the infrastructure of rpcClient is not suitable for those logging you want. But ctrl+c signal now is ready on #1680.

So I make this ticket as low priority, and will back to it later for logging.

mrpalide avatar Nov 29 '23 02:11 mrpalide

indeed, not a critical issue to solve currently.

0pcom avatar Dec 19 '23 15:12 0pcom