skywire icon indicating copy to clipboard operation
skywire copied to clipboard

Simplify the app settings API

Open Senyoret1 opened this issue 2 years ago • 1 comments

Currently, the PUT /visors/{pk}/apps/{app} API endpoint has one struct with a specific param for each setting in every app. This means that every new param in an app needs a new param in the struct, which is not really good for maintainability. Some time ago, Mohammad added a param called CustomSetting which can contain any param for future custom apps.

Maybe we should just use that param for all settings on all apps and every app should be responsible for checking its own settings, for separation of responsabilities and to simplify the code.

Senyoret1 avatar Jun 29 '23 22:06 Senyoret1

Fixed params just available for official apps, means current apps. CustomSetting use on user apps, so no problem be here. But I keep this issue open for review and deciding in future.

mrpalide avatar Nov 02 '23 07:11 mrpalide