skywire icon indicating copy to clipboard operation
skywire copied to clipboard

Config with dmsghttp + http services with bool to use dmsghttp

Open 0pcom opened this issue 2 years ago • 1 comments

Currently there are two types of visor config that can be created

  • config using <dmsg-pk>:<port> for the services
  • config using just http for the services

For the sake of simplicity and uniformity, we should consider having both dmsghttp and http services in the config file with a flag for config gen and a boolean field in the config which would enable the use of dmsghttp.

This would simplify testing, because changing one field would be all that is necessary to switch how the visor connects to the services. It would be easier, in terms of troubleshooting issues, to compare any config against any other config and verify that the keys for dmsghttp services are correct, or to test with a local visor connecting to services using dmsghttp.

0pcom avatar Jun 08 '23 14:06 0pcom

Follow up on this ; we should have both dmsghttp and regular http endpoints configured.

The visor should by default attempt to connect to any service over dmsghttp.

As a fallback, if the service is not available or can't be accessed over dmsghttp, then the http endpoint configured should be queried ; unless the visor is using dmsghttp, in which case the http endpoints should not be queried.

0pcom avatar Mar 05 '24 16:03 0pcom