skywire icon indicating copy to clipboard operation
skywire copied to clipboard

HVUI Wrong service discovery endpoint for skysocks

Open 0pcom opened this issue 3 years ago • 0 comments

The service discovery endpoint for socks5 servers (skysocks-server) was changed some time ago, but this change was not reflected in the frontend sources

the current (incorrect) endpoint being queried is here:

https://sd.skycoin.com/api/services?type=proxy

which causes the list of skysocks proxy servers to never populate / indefinite loading as pictured below

IMG_20221023_092807_412.jpg

the correct endpoint is here

https://sd.skycoin.com/api/services?type=skysocks

the fix should be applied here

https://github.com/skycoin/skywire/blob/7a0c6789306555162cdbb02cc90398a80d308dd7/static/skywire-manager-src/src/app/services/proxy-discovery.service.ts#L19

OR we should devise a way to avoid hardcoding this, which should avert similar errors in the future.

...

Also, a better error on null return from the service discovery should be reflected in the hypervisor UI. Perhaps even returning the endpoint which was queried; in such a way that a user may click a link to go to the service discovery endpoint for the specified service directly, which may be helpful for troubleshooting.

0pcom avatar Oct 23 '22 14:10 0pcom