Brian Slesinsky

For people who searched for this bug, a workaround is to set your own timeout using setTimer: ``` beforeEach(() => { setTimeout(() => {}, 1000); }); ``` (Perhaps failing with...

More context: Deno changed in early January to always type-check unstable API's. See: https://github.com/denoland/deno/pull/21825

That looks nice! Although, a drawback with only triggering when no menu items match is that the shortcut could change when more items are added to the menu. It seems...

I have an idea: making wrenInterpret reentrant may be simpler than making the Wren VM reentrant. Suppose we have a new kind of foreign method call that supports reentrancy? When...

That's unfortunate. Do you remember where those two places were?

I think there is no problem [^1], but since a search led me here and I just figured this out, maybe my explanation will help others: This is all about...

Based on the code, I think `phase` currently does something slightly different. It moves the phase by the delta between its argument and the previous call to `phase`. So, if...

It's not clear to me if we disagree or are just using different terminology, but I will try to explain better. By "current position" it seems you mean "the phase...

Here is how I edited my local copy. (I also added the code disabling interrupts.) ``` void begin(short t_type) { __disable_irq(); phase_offset = 0; phase_accumulator = 0; tone_type = t_type;...

If `begin()` cleared the phase accumulator, you could call `phase()` immediately after to set the phase. That seems a bit obscure though, compared to `phase()` actually setting the phase. Advancing...