toolkit icon indicating copy to clipboard operation
toolkit copied to clipboard

Larger spacing unit

Open MrDinsdale opened this issue 6 years ago • 2 comments

Is your feature request related to a problem? Please describe. 40px is currently our largest spacing unit but is often inadequate for spacing used in designs

Describe the solution you'd like Add a new 80px spacing unit i.e u-margin-top-ludicrous.

MrDinsdale avatar Aug 10 '18 14:08 MrDinsdale

If there are enough use cases for this then I say smash it in. Pretty certain I've had to do some mathery with the smaller spacing vars to get a larger value that I need.

steallan-sky avatar Aug 13 '18 14:08 steallan-sky

The value makes sense as 80px keeps the incremental pattern

For reference, our current values = default: 20px tiny: 5px (x0.25) small: 10px (x0.5) large: 20px (x2)

And so, ludicrous: 80px (x4)

However! I find I'm constantly having to check what these values equate to and we are in danger of playing top trumps(bigger than ludicrous? stupendous?). Would it be madness to suggest that we rename these to be more obvious as to what the values are actual going to result in?

something like:

  • quater
  • half
  • double
  • quadruple

e.g

u-margin-bottom-half

u-margin-bottom-quadruple

steveduffin avatar Aug 14 '18 08:08 steveduffin