toolkit icon indicating copy to clipboard operation
toolkit copied to clipboard

Card - Firefox shadow rendering issue

Open MrDinsdale opened this issue 7 years ago • 5 comments

Expected Behaviour

The shadow should sit under the card on all browsers.

Current Behaviour

In Firefox 59.0b4 The pseudo elements for the card shadow sits above the card content:

screen shot 2018-01-30 at 12 38 07

Attempted Fixes

  • Tried adjusting z-index to force shadows below card.
  • Tried rolling back to 2.11 when the c-card--static modifier was introduced but no impact.
  • The only solution found so far is by adding a c-card__inner element but isn't ideal and would be a breaking change.

Steps to Reproduce (for bugs)

  1. Go to https://www.sky.com/shop/mobile/phones in Firefox
  2. Observe the broken cards

Context

This causes rendering issues with live content but doesn't impact functionality.

Your Environment

Desktop, Firefox 59.0b4

MrDinsdale avatar Jan 30 '18 12:01 MrDinsdale

Digging a little deeper, this only seems to be caused by <button class="c-card">. Non buttons seem to render correctly.

MrDinsdale avatar Jan 31 '18 08:01 MrDinsdale

Currently the only fix I've found without breaking changes is to use <a> rather than the <button> for the c-card element. Not the most semantic but struggling to find an alternative.

MrDinsdale avatar Feb 16 '18 14:02 MrDinsdale

This appears to have been fixed in the latest Firefox release:

screen shot 2018-02-26 at 15 09 34

Will leave ticket open to keep an eye on the issue.

MrDinsdale avatar Feb 26 '18 15:02 MrDinsdale

This issue appeared again with FireFox 63.

Recommend we remove the pseudo shadows and replace with an animated box-shadow for an interim fix.

MrDinsdale avatar Feb 01 '19 12:02 MrDinsdale

@MrDinsdale, is it possible that this issue is resolved? Not seeing it in the most current version of Firefox or in Firefox Dev Edition. Otherwise, I'd be happy to take it on.

nellarro avatar Oct 05 '19 11:10 nellarro