toolkit icon indicating copy to clipboard operation
toolkit copied to clipboard

Published 20 hours ago • verified publisher icon sky-uk

Revisiting Icons

Open joe-bell opened this issue 8 years ago • 1 comments

Expected Behaviour

Long Term:

  • We should implement the new global icon system which is currently in development by @aaronthomas
  • Add generic icon styles to Toolkit

Short Term:

  • Tidy up what we currently have into a mixin or function; making it easier to maintain.
    • At the moment it’s the same chevron icon 4-5 times, a cross, a tick
  • Investigate an alternative to base64 PNG assets (if possible).
    • Note: SVG currentColor won’t inherit colours as a background-image. So we don't get any more flexibility in colour manipulation.

Current Behaviour

  • We currently use base64 PNG due to browser constraints when embedding SVGs as a background-image in a pseudo-element.

Attempted Fixes

Context

Currently working on https://github.com/sky-uk/toolkit/pull/324, and realised how sad it makes me.

joe-bell avatar Dec 01 '17 09:12 joe-bell

Is there any value to be gained in the short term step?

My vote is that we ear mark them for removal in 3.0 and follow the precedent set by the calendar (https://github.com/sky-uk/toolkit/blob/develop/packages/sky-toolkit-ui/components/_calendar.scss#L129) and overlay https://github.com/sky-uk/toolkit/blob/develop/packages/sky-toolkit-ui/components/_overlay.scss#L100 i.e just give the styles and mark them with comments in the exmaple HTML structure.

steveduffin avatar Dec 14 '17 14:12 steveduffin