sky-uk
Add regression tests for Cassandra 2.x and 3.x
CqlMigrate should work in both versions, and should be able to be tested within both versions. Could be done by creating three modules: one for CqlMigrate and two other for tests. The latter should share the tests meanwhile is possible (no break changes)
Something like this: https://github.com/joseblas/cqlmigrate/commits/SNS-with-regressiontests
Kinda... Though I think it might be overkill to have a copy of all of the unit tests for each version. The change I'd make, is to move most of the unit tests to the cql module. Then just have a copy of the CqlMigratorImplTest in each of the testX modules so that it's tested end to end for each version.
As a minor thing, I'd probably rename the cql module to something different as it doesn't contain any cql, possible even just calling it cqlmigrate?
Good start though :)
Hi Adam,
This is only an example how can be done.
I agree on the change of cql module to cqlmigrate, and the root one to cqlmigrate-parent (or similar).
And the tests are only in test2x, because are cassandra2 tests. In test3x there is only a ref to test2x.
To apply this a new fork should be done (or can I create a branch on the main project)
Regards, Jose.
On 29 Nov 2016, at 08:25, Adam Dougal [email protected] wrote:
Kinda... Though I think it might be overkill to have a copy of all of the unit tests for each version. The change I'd make, is to move most of the unit tests to the cql module. Then just have a copy of the CqlMigratorImplTest in each of the testX modules so that it's tested end to end for each version.
As a minor thing, I'd probably rename the cql module to something different as it doesn't contain any cql, possible even just calling it cqlmigrate?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.