skuzzymiglet
skuzzymiglet
@imsnif just checking, would it be worth my time giving this a shot?
`beep.ResampleRatio`, above a certain value. Really high tempos on my program (https://github.com/skuzzymiglet/metro) cause panic. In one case a 0.29s flac sample, resampled to 1/1000s is the minimum for a `panic()`
My trace: ``` panic: runtime error: index out of range [-9223372036854775296] goroutine 1 [running]: github.com/faiface/beep.(*Resampler).Stream(0xc0001b8000, 0xc0001ba000, 0x200, 0x200, 0xc0001b6000, 0x741a88) /home/skuzzymiglet/.local/go/pkg/mod/github.com/faiface/[email protected]/resample.go:96 +0x3eb github.com/faiface/beep.(*Buffer).Append(0xc0002b9f28, 0x81a5e0, 0xc0001b8000) /home/skuzzymiglet/.local/go/pkg/mod/github.com/faiface/[email protected]/buffer.go:198 +0x87 main.main() /home/skuzzymiglet/code/metro/main.go:135 +0x5c8...
I don't know about how to fix it. I guess we could use a `uint64` rather than `int64`. But the panic needs to be prevented
Hey @jiazhiguy, I got this panic when I did a `ResampleRatio` with an infinite (division by zero). Is this what happened?
As far as I can see, it's https://github.com/gen2brain/aac-go, but that's a cgo binding
Well, a `while` could work but I need a loop. I'm resampling it dynamically later, and it's more precise generally.
@faiface A potential solution to this problem is a `chan whatever` that signals before each sample in a `beep.Seq`. Something like `beep.SeqChan(channel, beep.Loop(stuff))`
Hey @acaudwell, is this a feature that could be implemented?
Sorry, I didn't find a solution. I was just closing stale issues I'd opened