Updating SkupperPodmanSite.Status to check if site.AuthMode is internal.

[Karen-Schoener]

Fixes #1389

[Karen-Schoener]

Please see below for manual test results. Tests ran on fedora.

Test case: configure console, --console-auth unsecured:

$ skupper --platform podman init  --enable-console --console-auth unsecured  --enable-flow-collector 

$ ./skupper --platform podman status
Skupper is enabled for "kschoener" with site name "fedora-kschoener-e2de0". It is not connected to any other sites. It has no exposed services.
The site console url is:  https://0.0.0.0:8010

Test case: configure console with internal auth:

$ skupper --platform podman init --enable-console --enable-flow-collector

$ ./skupper --platform podman status
Skupper is enabled for "kschoener" with site name "fedora-kschoener-e7c35". It is not connected to any other sites. It has no exposed services.
The site console url is:  https://0.0.0.0:8010
The credentials for internal console-auth mode are held in podman volume: 'skupper-console-users'

[Karen-Schoener]

I noticed that there are two spaces after The site console url is: (this is not related to your change, but it would be nice to have it fixed as well).

There is also an extra line being displayed at the end. Do you mind removing it?

Thanks for the review.

Updated with the suggestions. Hope it's ok that I used fmt.Printf("...\n") instead of fmt.Println().

Re-ran test case by hand: configure console, --console-auth unsecured:

[kschoener@fedora skupper]$ ./skupper --platform podman status
Skupper is enabled for "kschoener" with site name "fedora-kschoener-1468e". It is not connected to any other sites. It has no exposed services.
The site console url is: https://0.0.0.0:8010
[kschoener@fedora skupper]$

Re-ran test case by hand: configure console with internal auth:

[kschoener@fedora skupper]$ ./skupper --platform podman status
Skupper is enabled for "kschoener" with site name "fedora-kschoener-0edbc". It is not connected to any other sites. It has no exposed services.
The site console url is: https://0.0.0.0:8010
The credentials for internal console-auth mode are held in podman volume: 'skupper-console-users'
[kschoener@fedora skupper]$

[Karen-Schoener]

Out of curiosity, I was wondering if this first line of skupper status should be split into 3 separate lines?

Skupper is enabled for "kschoener" with site name "fedora-kschoener-0edbc". It is not connected to any other sites. It has no exposed services.

Just thought I'd double-check...

Planning to leave as-is unless there's feedback.

[nluaces]

@Karen-Schoener thanks for your pull request!

Out of curiosity, I was wondering if this first line of skupper status should be split into 3 separate lines?

At present it would affect all the tests that check the output of the skupper status, I would not recommend it for now.

[Karen-Schoener]

Rebased with the the latest in skupper/main.

[Karen-Schoener]

I believe that the review comments have been addressed.

@fgiorgetti when time allows, would you mind letting me know if the PR looks ok? Thanks in advance, Karen