skulptur
skulptur
- Title and description: what should they contain? - Encourage self review - Scope of the PRs (smaller, focused) - Giving feedback - Receiving feedback (closing the comments with a...
It would be useful to have a .md file to link to when making code reviews. Each refactoring would have a code/name, a description, as well as examples of before...
If the data is incorrect, JSON.parse will throw. At the very least I think it should be mentioned in the docs that it is important/good practice to try/catch. Ideally there...
https://github.com/mediamonks/frontend-coding-standards/tree/feature/readme#folders example according to that: app/component/block -> app/components/blocks
As the title says, I think those 2 directories can be gone. IAbstractComponentMixin should be moved to where it's used if really needed at all.
https://github.com/mediamonks/muban/blob/master/src/app/bootstrap.dev.ts https://github.com/mediamonks/muban/blob/master/src/app/bootstrap.dist.ts https://github.com/mediamonks/muban/blob/master/src/app/partials.js https://github.com/mediamonks/muban/blob/master/src/app/polyfills.js
Consider src/app/component/app/*
I think the util directory should have a subdir deviceStateTracker by default with these files: https://github.com/mediamonks/muban/blob/master/src/app/data/shared-variable/media-queries.json https://github.com/mediamonks/muban/blob/master/src/app/util/deviceStateTracker.ts And then we remove data/shared-variable
https://github.com/mediamonks/muban/blob/master/src/app/muban/knockoutUtils.ts I don't think it's commonly used, or should be in a lib if it is important
https://github.com/mediamonks/muban/tree/master/src/app/data https://github.com/mediamonks/muban/tree/master/src/data Those have the same name but very different uses which makes it confusing