skpro icon indicating copy to clipboard operation
skpro copied to clipboard

[ENH] Check for distribution objects and handle them with iat/iloc

Open SimonBlanke opened this issue 1 month ago • 7 comments

Reference Issues/PRs

resolves #559

What does this implement/fix? Explain your changes.

The source code changes are just the isinstance check for distribution objects and using iat/iloc for scalars or arrays. This PR also adds multiple tests and the _CompositeDistributionTester (which is used in the new tests).

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • [ ] I've added myself to the list of contributors with any new badges I've earned :-) How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release. See here for full badge reference
  • [ ] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • [ ] I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • [ ] I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • [ ] If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured dependency isolation, see the estimator dependencies guide.

SimonBlanke avatar Nov 22 '25 14:11 SimonBlanke